[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119
+    ++End;
+  return llvm::makeArrayRef(&Actions[Start], &Actions[End]);
+}
----------------
hokein wrote:
> aaron.ballman wrote:
> > This is causing an assertion with debug builds on Windows because `Actions[End]` is out of bounds (so the MSVC STL debug assertions catch the issue) for the test cases in this patch.
>  this should be `llvm::makeArrayRef(&Actions[Start], End - Start)`. Fixed in 302ca279cb83043ef7d60115eb5ba58f12064a4a.
I can confirm that the issue is now fixed for me, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118196/new/

https://reviews.llvm.org/D118196