[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 11:47:30 PST 2022


ymandel added a comment.

High level question: why use `Any` rather than templating?



================
Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:68
 
+using AnyGenerator2 = std::shared_ptr<MatchComputation<llvm::Any>>;
+
----------------
li.zhe.hua wrote:
> Placeholder name; suggestions welcome.
hmm. How about MetadataGenerator? Less general, but to the point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120360/new/

https://reviews.llvm.org/D120360



More information about the cfe-commits mailing list