[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 23 11:43:01 PST 2022
aaron.ballman added a comment.
Hi, this commit is causing runtime failures on Windows in debug builds. Can you please correct or revert? Thanks!
================
Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119
+ ++End;
+ return llvm::makeArrayRef(&Actions[Start], &Actions[End]);
+}
----------------
This is causing an assertion with debug builds on Windows because `Actions[End]` is out of bounds (so the MSVC STL debug assertions catch the issue) for the test cases in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118196/new/
https://reviews.llvm.org/D118196
More information about the cfe-commits
mailing list