[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 08:47:58 PST 2022


cor3ntin added a comment.

I like this approach. it seems a lot easier to maintain as people don't have to remember to use LangOptionsBase to not degrade performance



================
Comment at: clang/include/clang/Lex/Lexer.h:94
+  // LangOpts enabled by this language.
+  const LangOptions &LangOpts;
+
----------------
Should we add a comment to explain why this is a reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334



More information about the cfe-commits mailing list