[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added a comment.

In D120353#3340606 <https://reviews.llvm.org/D120353#3340606>, @ABataev wrote:

> In D120353#3340596 <https://reviews.llvm.org/D120353#3340596>, @jhuber6 wrote:
>
>> If we have `#pragma omp target if (...)` then that requires a host fallback and violates the assertion the user passed in, it will hit the unreachable and fail. If the user passed in `#pragma omp target device(...)` we will assume that a host implementation exists as well.
>
> Do you have a check for the last case (with the device clause)?

In the test file I had a global, but forgot to check the globals to show that `@x` exists on the device. I should also put an `if (0)` to show that we always hit unreachable in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120353/new/

https://reviews.llvm.org/D120353