[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

Wed Feb 23 07:59:40 PST 2022

awarzynski added a comment.

Thank you both for taking a look!

In D120246#3339284 <https://reviews.llvm.org/D120246#3339284>, @rovka wrote:

> Nit: Should we also have a test for print-effective-triple?

Added.

> I'm not sure that -emit-llvm is necessarily something we'd want flang users to be exposed to.

Hm, but that's what `clang` does and we probably want to keep `flang-new` and `clang` consistent. And we can't hide `-emit-llvm` without hiding it in `clang`as well  (so `HelpHidden` is not really an option).

In D120246#3339289 <https://reviews.llvm.org/D120246#3339289>, @tschuett wrote:

> https://reviews.llvm.org/D117809
>
> There was a discussion that `-emit-llvm` is considered a mistake.

Which comment are you referring to specifically? Also, `-emit-llvm` is something that Flang inherits from Clang. I'm merely making it available in `flang-new` rather than re-defining it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120246/new/

https://reviews.llvm.org/D120246