[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

Michael Colavita via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 06:45:46 PST 2022


colavitam added a comment.

Yes, in my opinion the original shadow was accidental—you can see that every usage of BaseTypeLoc is immediately preceded by an initialization, though sometimes in a more nested scope. When initialized in the parameter pack loop, we skip to the next iteration of the outer loop instead of accessing it in the non-parameter pack path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119063/new/

https://reviews.llvm.org/D119063



More information about the cfe-commits mailing list