[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

Dawid Jurczak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 06:06:13 PST 2022


yurai007 added a comment.

In D120334#3339764 <https://reviews.llvm.org/D120334#3339764>, @serge-sans-paille wrote:

> A small local test hints that using a ``SmallVector`` instead of a ``std::vector`` also fixes the assembly bloat. I don't know if it's worth considering as an alternative or  as an extra step.

Ok, I'm gonna try SmallVectors on top of this change. LangOptions is widely used so maybe it could bring some extra gains in places where vectors are indeed filled with more data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334



More information about the cfe-commits mailing list