[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

Luis Penagos via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 05:49:21 PST 2022


penagos marked an inline comment as done.
penagos added a comment.

In D120374#3339554 <https://reviews.llvm.org/D120374#3339554>, @curdeius wrote:

> In D120374#3339337 <https://reviews.llvm.org/D120374#3339337>, @penagos wrote:
>
>> Though it's still unclear to me whether or not it'd make more sense to continue to pursue a change to introduce `C` as a language. Thoughts?
>
> I prefer your current approach (and there should be not that many cases that we need a special treatment for C).

Makes sense. I'll also need someone to commit on my behalf:

- Luis Penagos
- luis at penagos.co

Thanks!



================
Comment at: clang/unittests/Format/FormatTest.cpp:9926
+            format("void new (link p);\n"
+                   "void delete(link p);\n"));
 }
----------------
curdeius wrote:
> Why there's no space after `delete` in the input?
Whoops, good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120374/new/

https://reviews.llvm.org/D120374



More information about the cfe-commits mailing list