[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 22 11:00:01 PST 2022


craig.topper added inline comments.


================
Comment at: clang/lib/Headers/avx512fintrin.h:5944
+      (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C),     \
+      (unsigned char)(imm), (__mmask16)-1))
+
----------------
Why do we need to change the type on `imm` here? The builtin takes an int, and the enum you created defaults to int. Is this so we truncate ~ to 8-bits?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120307/new/

https://reviews.llvm.org/D120307



More information about the cfe-commits mailing list