[PATCH] D120149: [clang][dataflow] Add support for global storage values

Tue Feb 22 10:03:22 PST 2022

xazax.hun added a comment.

In D120149#3333056 <https://reviews.llvm.org/D120149#3333056>, @sgatev wrote:

> I think we should provide such functionality and it probably should also apply to some of the pointer and reference values. Not sure what the default should be, but having the ability to choose the level of soundness for certain analyses is valuable so I think both options should be possible. We don't have that implemented yet and I think it might be better to consider this together with other improvements that we want to make such as lazy value initialization. Would you be ok with deferring this for now? I noted it with a FIXME in the code.

I think the default should be as sound as reasonably possible. If we don't do any invalidations, I'd like to see some sort of warning somewhere so early users are aware of the behavior. I'm not sure what is the best place to put the warning, maybe to the documentation of a class? With that warning in place, I think it is ok to commit this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120149/new/

https://reviews.llvm.org/D120149