[PATCH] D120271: [Clang] Add offload kind to embedded offload object

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added a comment.

In D120271#3338034 <https://reviews.llvm.org/D120271#3338034>, @saiislam wrote:

> Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object?
> The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some more information.
>
> [1] https://clang.llvm.org/docs/ClangOffloadBundler.html#bundle-entry-id

It might also be useful for PTX, considering when we do LTO we need to know the target features (e.g. +ptx74). As long as it's a valid section name anything goes, especially as things get more complex like when we may want to embed both PTX and cubins, or maybe always embed bitcode for option JIT use. This change definitely brings us closer to what we had in the old offload bundler so we could unify that somewhat. That could be the topic of a future patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120271/new/

https://reviews.llvm.org/D120271