[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

[Cristian Adam via Phabricator via cfe-commits]

cristian.adam added a comment.

In D119199#3337699 <https://reviews.llvm.org/D119199#3337699>, @vtjnash wrote:

> Is that a bug in clang or in MSVC2019? We expected that CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we add new tests here for verifying that configuration is functioning as expected. You might need to disable CLANG_PLUGIN_SUPPORT on that target?

I don't know. I "fixed" it by commenting out the whole creation of the target, the same way as the `LLVM_INSTALL_TOOLCHAIN_ONLY` does, which would be the other workaround, to just use `LLVM_INSTALL_TOOLCHAIN_ONLY`.

  diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
  index 170e5f8bd197..e8b897893776 100644
  --- a/clang-tools-extra/test/CMakeLists.txt
  +++ b/clang-tools-extra/test/CMakeLists.txt
  @@ -80,6 +80,7 @@ foreach(dep ${LLVM_UTILS_DEPS})
     endif()
   endforeach()
  
  +#[[
   if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
     llvm_add_library(
         CTTestTidyModule
  @@ -106,6 +107,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
         endif()
     endif()
   endif()
  +#]]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119199/new/

https://reviews.llvm.org/D119199