[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 22 02:26:03 PST 2022


kbobyrev added a comment.

In D120306#3337212 <https://reviews.llvm.org/D120306#3337212>, @sammccall wrote:

> What's the policy this patch intends to implement?
>
> I'm a little concerned by building up maps of filenames with segment limits - it looks like some kind of heuristic/partial matching.

Basically, handling the mappings that. IWYU pragmas provide.

Are you concerned about the limit itself or the way I'm trying to find these headers in general? I was afraid of consuming too much memory, hence the limit; it's not crucial to the implementation, though, I can remove it if your concern is the limit rather than the approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120306/new/

https://reviews.llvm.org/D120306



More information about the cfe-commits mailing list