[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 21 13:47:28 PST 2022


jdoerfert added a comment.

Can we have a test for this?



================
Comment at: clang/include/clang/CodeGen/BackendUtil.h:48
 
-  void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts,
                    DiagnosticsEngine &Diags);
----------------
Seems unrelated, please remove it from this patch.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1774
                                           "could not open '%0' for embedding");
-      Diags.Report(DiagID) << std::get<0>(FilenameAndSection);
       return;
----------------
Same as above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120270/new/

https://reviews.llvm.org/D120270



More information about the cfe-commits mailing list