[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 21 09:16:14 PST 2022


sammccall created this revision.
sammccall added reviewers: nridge, Trass3r.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

This takes a similar approach as b9b6938183e <https://reviews.llvm.org/rGb9b6938183e837e66ff7450fb2b8a73dce5889c0>, and shares some code.
The code sharing is limited as inlay hints wants to deduce the type of the
variable rather than the type of the `auto` per-se.

It drops support (in both places) for multiple instantiations yielding the same
type, as this is pretty rare and hard to build a nice API around.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120258

Files:
  clang-tools-extra/clangd/AST.cpp
  clang-tools-extra/clangd/AST.h
  clang-tools-extra/clangd/InlayHints.cpp
  clang-tools-extra/clangd/unittests/ASTTests.cpp
  clang-tools-extra/clangd/unittests/InlayHintTests.cpp
  clang-tools-extra/clangd/unittests/TestTU.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120258.410325.patch
Type: text/x-patch
Size: 15431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220221/ccb45702/attachment.bin>


More information about the cfe-commits mailing list