[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

Son Tuan Vu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 21 08:29:28 PST 2022


tyb0807 added inline comments.


================
Comment at: clang/lib/Basic/Targets/ARM.cpp:958
   case llvm::ARM::ArchKind::ARMV8_6A:
+  case llvm::ARM::ArchKind::ARMV8_7A:
   case llvm::ARM::ArchKind::ARMV8_8A:
----------------
SjoerdMeijer wrote:
> I see tests for the crypto stuff, but is there or do we need a test for whatever `getTargetDefinesARMV83A` is setting?
I'm not sure that we need a test for this, as none of the other architectures really have this. What do you think @SjoerdMeijer @vhscampos ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116153/new/

https://reviews.llvm.org/D116153



More information about the cfe-commits mailing list