[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

[Iain Sandoe via Phabricator via cfe-commits]

iains added a comment.

In D118586#3335235 <https://reviews.llvm.org/D118586#3335235>, @ChuanqiXu wrote:

> In D118586#3335191 <https://reviews.llvm.org/D118586#3335191>, @iains wrote:
>
>> In D118586#3335167 <https://reviews.llvm.org/D118586#3335167>, @ChuanqiXu wrote:
>>
>>> I think it is helpful to add some tests from https://reviews.llvm.org/D113972
>>
>> Actually, in response to your concerns, this morning I wrote a multi-partition test case to add to this (which does pass).
>
> Thanks. I think it would be helpful to add it here.
>
>> Would you be able to split out the important test cases from D113972 <https://reviews.llvm.org/D113972> as a separate patch ?
>
> I found the meaningful test case mainly comes from the example in spec. e.g., http://eel.is/c++draft/module.unit#4, http://eel.is/c++draft/module.unit#4, http://eel.is/c++draft/module.unit#4

Right, actually it is my intention to have each of the examples in the std as a test case (this is what I have in my working branch) but, obviously, we can only introduce them when the features they show are implemented.  So (for example) 4/8 adds 10.1 examples 1 and 2.   5/8 adds in 10.3 ex1 and ex2 .. and so on ..

However, maybe I should review if some of the others should be accepted already :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118586/new/

https://reviews.llvm.org/D118586