[PATCH] D119562: Provide fine control of color in run-clang-tidy

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:240-249
+  color_group = parser.add_mutually_exclusive_group()
+  color_group.add_argument('-use-color', action='store_true', dest='use_color',
+                           help='Use colors in diagnostics, overriding clang-tidy\'s default '
+                           'behavior. This option overrides the \'UseColor\' option in'
+                           '.clang-tidy file, if any.')
+  color_group.add_argument('-no-use-color', action='store_false', dest='use_color',
+                           help='Do not use colors in diagnostics, overriding clang-tidy\'s default'
----------------
All the arguments to this script mirror clang-tidy arguments, therefore I'm against introducing gnc style command line flags for controlling colour output. I'd suggest something like this which mirrors clang-tidys behaviour much more closely,
This requires an import
```lang=py
from distutils.util import strtobool```
Tbh it may be better writing a strtobool that is in sync with llvms command line bool parser
```
{ "true", "TRUE", "True", "1"` -> true }
{ "false", "FALSE", "False", "0" -> false }
{ ... -> Error }

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119562/new/

https://reviews.llvm.org/D119562