[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 19 15:15:37 PST 2022

Previous message: [PATCH] D117973: [cmake] Support custom package install paths
Next message: [PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

njames93 added a comment.

Was there any real use case for making this polymorphic, The overhead for a virtual function call seems a little unnecessary IMO?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113422/new/

https://reviews.llvm.org/D113422

Previous message: [PATCH] D117973: [cmake] Support custom package install paths
Next message: [PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list