[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

Fri Feb 18 17:17:57 PST 2022

keith added a comment.

In D102669#3325467 <https://reviews.llvm.org/D102669#3325467>, @steakhal wrote:

> Hi @keith, I've seen you commented on a clang driver-related issue: "Why does march=native not work on Apple M1?" <https://discourse.llvm.org/t/why-does-march-native-not-work-on-apple-m1/2733>
> You might also have some valuable insight about this weird behavior about the detected target triple in a regular mode and using the `-cc1` mode.
> You don't need to go through the whole conversation, the last few comments should be enough.
> Feel free to invite more people if you think.

I'm not very familiar with the logic or history here, but I did look into this a bit, and I don't see a clear solution. I think the logic that lives in the Darwin driver code for creating the triple would have to be called from the default triple logic that's used in the cc1 case. I imagine to make this test pass you'd be best off making sure you always call clang or cc1, and not intermix them, or provide a default triple in all cases that's stable if possible. I do think it would be nice to unify the triple logic between these 2 places, but I imagine folks who know this code better than I do have opinions there.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102669/new/

https://reviews.llvm.org/D102669