[PATCH] D120149: [clang][dataflow] Add support for global storage values

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 18 14:14:55 PST 2022


xazax.hun added a comment.

Shouldn't there be a functionality to invalidate all the globals at every function call by default?



================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:141
+    // Global vars are already initialized in `Environment`.
+    if (D.hasGlobalStorage())
+      return;
----------------
Do we expect to ever see a global declaration in a transfer function? Or is this for static locals? If it is for the latter, I'd adjust the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120149/new/

https://reviews.llvm.org/D120149



More information about the cfe-commits mailing list