[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 18 13:27:07 PST 2022


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6
+/// Check sparc-sun-solaris2.11, 32bit
+// RUN: %clang %s -### 2>&1 \
+// RUN:     --target=sparc-sun-solaris2.11 \
----------------
The first line is now shorter. You can move --target= above.

For me, the number of lines of a test counts and sometimes compacter RUN lines improve readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119829/new/

https://reviews.llvm.org/D119829



More information about the cfe-commits mailing list