[PATCH] D120115: [clangd] Tweak --query-driver to ignore slash direction on windows

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!



================
Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:278
+    } else if (llvm::sys::path::is_separator(Glob[I]) &&
+               llvm::sys::path::is_separator('/') &&
+               llvm::sys::path::is_separator('\\')) {
----------------
nit: maybe extract `llvm::sys::path::is_separator('/') && llvm::sys::path::is_separator('\\')` into a `bool PlatformIsSlashInsensitive` ?


================
Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:298
 
+  // Tempting to pass IgnoreCase, but we don't the FS sensitivity precisely.
   llvm::Regex Reg(llvm::join(RegTexts, "|"));
----------------
we don't `know` the FS .. ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120115/new/

https://reviews.llvm.org/D120115