[PATCH] D112916: Confusable identifiers detection

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 17 19:10:42 PST 2022


rsmith added a comment.

In D112916#3290365 <https://reviews.llvm.org/D112916#3290365>, @serge-sans-paille wrote:

> @rsmith : once the licensing issue has been fixed, can we merge that patch or do you have any other thought?

I have no concerns once the licensing question is resolved and the other reviewers are happy. I agree with Corentin that we should be exactly following the Unicode Consortium's recommendations. I think that while this doesn't fully address Aaron's concern, it at least gives us a rationale for our treatment of different scripts and seems more defensible than our coming up with some additional rules of our own.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112916/new/

https://reviews.llvm.org/D112916



More information about the cfe-commits mailing list