[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

[Krystian Kuzniarek via Phabricator via cfe-commits]

kuzkry added a comment.

First of all, thanks @MyDeveloperDay for the approval.

In D119682#3321965 <https://reviews.llvm.org/D119682#3321965>, @MyDeveloperDay wrote:

> @HazardyKnusperkeks could you validate the `IndentRequiresClause` I know I added `IndentRequires` in 13 but is this the same option renamed or a new option?

This was renamed and it was done in 9aab0db13fb6d21d1b70247a9b5e4cf916ee1c3a <https://reviews.llvm.org/rG9aab0db13fb6d21d1b70247a9b5e4cf916ee1c3a>.

In D119682#3321975 <https://reviews.llvm.org/D119682#3321975>, @MyDeveloperDay wrote:

> I understand what you are saying re 'IndentRequiresClause' but this leaves us with people with "IndentRequires" in their .clang-format without any understanding of what it means? i.e. what about the 14.0 people? if we've renamed an option then the documentation should carry something like
>
> 'Previously known as IndentRequires'

I have no problems with adding it myself if you want. I think this is //nice to have// and I see nothing wrong in adding it.

In D119682#3322082 <https://reviews.llvm.org/D119682#3322082>, @HazardyKnusperkeks wrote:

> In D119682#3321975 <https://reviews.llvm.org/D119682#3321975>, @MyDeveloperDay wrote:
>
>> I understand what you are saying re 'IndentRequiresClause' but this leaves us with people with "IndentRequires" in their .clang-format without any understanding of what it means? i.e. what about the 14.0 people? if we've renamed an option then the documentation should carry something like
>>
>> 'Previously known as IndentRequires'
>
> That's not the first time we renamed something. And most likely not the last time.

But that doesn't mean we can't add "Previously known as IndentRequires", does it? :)

To all:
I'm willing to add "Previously known as IndentRequires" but please let me know if you're for or against it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119682/new/

https://reviews.llvm.org/D119682