[PATCH] D120066: FileCheck’s regexp stumped on Windows.

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 17 08:28:53 PST 2022


zahiraam created this revision.
zahiraam added a reviewer: erichkeane.
zahiraam requested review of this revision.
Herald added a project: clang.

We found that on Windows the regular expression used to describe the link command from the last RUN command of the LIT test debug-info-hotpatch.cpp, is not matching the link command.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120066

Files:
  clang/test/CodeGenCXX/debug-info-hotpatch.cpp


Index: clang/test/CodeGenCXX/debug-info-hotpatch.cpp
===================================================================
--- clang/test/CodeGenCXX/debug-info-hotpatch.cpp
+++ clang/test/CodeGenCXX/debug-info-hotpatch.cpp
@@ -12,8 +12,8 @@
 // RUN: %clang_cl --target=x86_64-windows-msvc /hotpatch -### -- %s 2>&1 \
 // RUN:    | FileCheck %s --check-prefix=FUNCTIONPADMIN
 // FUNCTIONPADMIN: clang{{.*}}
-// FUNCTIONPADMIN: {{link.*"}}
-// FUNCTIONPADMIN: -functionpadmin
+// FUNCTIONPADMIN: {{link[^"]*"}} 
+// FUNCTIONPADMIN: "-functionpadmin"
 
 int main() {
   return 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120066.409667.patch
Type: text/x-patch
Size: 575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220217/2887e01c/attachment.bin>


More information about the cfe-commits mailing list