[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

Thu Feb 17 08:20:13 PST 2022

jrtc27 added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/double-mem.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc -mtriple=riscv32 -mattr=+d -verify-machineinstrs < %s \
+; RUN: llc -mtriple=riscv32 -mattr=+d -target-abi=ilp32 -verify-machineinstrs < %s \
 ; RUN:   | FileCheck -check-prefix=RV32IFD %s
----------------
For a bunch of these it seems it'd make more sense to just use a hard-float ABI. I think it's worthwhile keeping this as NFC test-wise, but don't know if it makes sense to update the ABIs first and make this patch smaller or land this then go through at a later date so as to not stall this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118333/new/

https://reviews.llvm.org/D118333