[PATCH] D114425: [clang] Add __builtin_bswap128

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 17 06:05:28 PST 2022


erichkeane added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:10987
   case 'i':
-    if (HowLong == 3)
+    if (HowLong == 3) {
+      if (!AllowInt128 && !Context.getTargetInfo().hasInt128Type()) {
----------------
Please add a test in Sema as well to validate the diagnostic so we can ensure it sounds sane.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114425/new/

https://reviews.llvm.org/D114425



More information about the cfe-commits mailing list