[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:28
+
+  /// Returns the environment of the basic block that contains `S` or nullptr if
+  /// there isn't one.
----------------
xazax.hun wrote:
> Depending on how willing sensitive we are to memory vs runtime, if there is one environment per basic block, we could look up the basic block of the statement, and use the basic block's id, to look up the environment in a vector.
Whoops, never mind. The implementation already reflects what I suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119953/new/

https://reviews.llvm.org/D119953