[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers
Jun Zhang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 16 08:03:17 PST 2022
junaire created this revision.
junaire added reviewers: aaron.ballman, alexfh.
Herald added subscribers: carlosgalvezp, xazax.hun.
junaire requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
The ElaboratedType can have no qualifiers, so we should check it before
use.
Fix #issue53874(https://github.com/llvm/llvm-project/issues/53874)
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D119949
Files:
clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp
Index: clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp
+++ clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp
@@ -197,6 +197,15 @@
h<4>();
}
+struct SP {
+ static int I;
+} P;
+
+void usep() {
+ P.I;
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member
+ // CHECK-FIXES: {{^}} struct SP::I;{{$}}
+}
// Overloaded member access operator
struct Q {
Index: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp
+++ clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp
@@ -19,14 +19,15 @@
static unsigned getNameSpecifierNestingLevel(const QualType &QType) {
if (const ElaboratedType *ElType = QType->getAs<ElaboratedType>()) {
- const NestedNameSpecifier *NestedSpecifiers = ElType->getQualifier();
- unsigned NameSpecifierNestingLevel = 1;
- do {
- NameSpecifierNestingLevel++;
- NestedSpecifiers = NestedSpecifiers->getPrefix();
- } while (NestedSpecifiers);
-
- return NameSpecifierNestingLevel;
+ if (const NestedNameSpecifier *NestedSpecifiers = ElType->getQualifier()) {
+ unsigned NameSpecifierNestingLevel = 1;
+ do {
+ NameSpecifierNestingLevel++;
+ NestedSpecifiers = NestedSpecifiers->getPrefix();
+ } while (NestedSpecifiers);
+
+ return NameSpecifierNestingLevel;
+ }
}
return 0;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119949.409270.patch
Type: text/x-patch
Size: 1746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220216/c64e0aa3/attachment.bin>
More information about the cfe-commits
mailing list