[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:54
+------------------
+- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional``
+  wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array
----------------
aaron.ballman wrote:
> Just added a reference to the bug that was fixed.
I was wondering about this. Where does the "PRXXXXXX" syntax come from? Since the repo and issues are on github now, I don't see how it makes sense to call it a PR (it's an issue, not a pull request) and github doesn't linkify those, while it does when using the `#xxxxxx` syntax (which isn't relevant in this case, but it is when using it in git commit messages). I have seen other people use the same syntax to refer to issues. I'd probably just add an actual link to the github issue here if that's permitted. Thanks for the suggestion though, I'm on PTO this week so don't land this until Monday  :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119525/new/

https://reviews.llvm.org/D119525