[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

[JunMa via Phabricator via cfe-commits]

junparser added inline comments.


================
Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654
+    cast<ReturnStmt>(Ret)->setRetValue(nullptr);
     EmitStmt(Ret);
+  }
----------------
ChuanqiXu wrote:
> junparser wrote:
> > I mean, remove the if statements here since the retuen expr is null.
> We couldn't. Since we need emit ret instruction if needed.
make sense to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117087/new/

https://reviews.llvm.org/D117087