[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 15 18:20:50 PST 2022


ChuanqiXu added inline comments.


================
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
----------------
According to [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | P1857R3 ]], it might not be good to add macro declarative before module declaration. Although clang didn't implement it and there are old test case uses this style, I think it might be better to split into files. @urnathan how do you think about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119823/new/

https://reviews.llvm.org/D119823



More information about the cfe-commits mailing list