[PATCH] D119825: [clang][lex] Introduce `SearchDirIndex` to usage tracking code

Alex Hoppen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 15 06:58:54 PST 2022


ahoppen added a comment.

Definitely a lot nicer 👍



================
Comment at: clang/include/clang/Lex/HeaderSearch.h:185
+  /// Get search directory stored at the index.
+  DirectoryLookup &get(HeaderSearch &HS) const;
+};
----------------
I would have expected these to be methods on `HeaderSearch`. Is there a particular reason why these are methods on `SearchDirIdx`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119825/new/

https://reviews.llvm.org/D119825



More information about the cfe-commits mailing list