[PATCH] D119560: [OpenCL] opencl-c.h: remove arg names from atomics

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.



> also makes the header no longer "claim" the identifiers "success",
> "failure", "desired", "value" (such that you can compile with -Dvalue=...
> when including the header for example, which currently breaks parsing
> of the header).

I don't get what you mean by this. :)

> This is a big patch and it only touches the OpenCL 2 atomics for now. I
> wonder if we should remove argument names from the other builtins too?
> I think it would help unifying the header and tablegen approaches: if we
> gradually move the header into some canonical form, we might be able
> to eventually replace it with a tablegen-ed header, while being able to
> easily confirm equivalence.

The only drawback I see if that we will lose the history a bit in "git blame" but:

- The biggest part of the header was committed in one block anyway
- We should drive toward deprecation of the header development and moving it

towards testing only feature.
So I think this is totally justifiable since it is a good step towards the end goal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119560/new/

https://reviews.llvm.org/D119560