[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 15 00:47:17 PST 2022
jansvoboda11 added inline comments.
================
Comment at: clang/include/clang/Lex/Preprocessor.h:2207
+ const FileEntry *&LookupFromFile) const;
+
/// Install the standard preprocessor pragmas:
----------------
ahoppen wrote:
> I there a reason why this uses an out parameter instead of a returning a `std::pair` or something similar? If yes, I think it would be good to document which parameters are out parameters. `IncludeNextTok` looks suspiciously like an out-parameter as well but is not AFAICT.
Not really. Switched to using `std::pair` and `std::tie` in the latest revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119716/new/
https://reviews.llvm.org/D119716
More information about the cfe-commits
mailing list