[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

[Raúl Peñacoba via Phabricator via cfe-commits]

rpenacob added a comment.

To test that this change does not break anything we built clang trunk with the patch. Our stage one looks like this.

-DCMAKE_INSTALL_PREFIX=/path/to/stage-one
-DCMAKE_BUILD_TYPE=Release
-DLLVM_ENABLE_PROJECTS=clang
-DLLVM_ENABLE_RUNTIMES="libcxx;compiler-rt;libcxxabi;libunwind"
-DCLANG_DEFAULT_RTLIB=compiler-rt
-DCLANG_DEFAULT_UNWINDLIB=libunwind
-DCLANG_DEFAULT_CXX_STDLIB=libc++
-DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON    # We don't have multilib for i386 in this test system
-DLLVM_USE_LINKER=lld

Then we built a stage two using the stage one (-DCMAKE_C_COMPILER and -DCMAKE_CXX_COMPILER pointing to stage-one's clang and clang++) with only -DLLVM_ENABLE_PROJECTS=clang. No test failed.

(We had to set LD_LIBRARY_PATH to /path/to/stage-one/lib/x86_64-unknown-linux-gnu so it finds runtime libs like libc++ and such.)

Do you think this is enough testing? Perhaps there is something else we could try.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118700/new/

https://reviews.llvm.org/D118700