[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

Augie Fackler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 14 09:36:54 PST 2022


durin42 added a comment.

In D114543#3319638 <https://reviews.llvm.org/D114543#3319638>, @chill wrote:

> In D114543#3319587 <https://reviews.llvm.org/D114543#3319587>, @durin42 wrote:
>
>> 
>
>
>
>> Is the parameter optional if uwtable is set programmatically, or only when we're reading IR streams?
>
> No, it's not optional, the attribute is added by https://github.com/llvm/llvm-project/blob/00cd6c04202acf71f74c670b2dd4343929d1f45f/llvm/include/llvm/IR/Function.h#L636
> (although seting it to `None` is semantically as not setting it at all).

Okay, that makes sense then. I think I was close to getting to that point by looking at this patch, but you saved me some time. Thanks!

/me off to write matching patch for Rust


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114543/new/

https://reviews.llvm.org/D114543



More information about the cfe-commits mailing list