[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

Alex Hoppen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 14 09:07:33 PST 2022


ahoppen added inline comments.


================
Comment at: clang/include/clang/Lex/Preprocessor.h:2207
+                           const FileEntry *&LookupFromFile) const;
+
   /// Install the standard preprocessor pragmas:
----------------
I there a reason why this uses an out parameter instead of a returning a `std::pair` or something similar? If yes, I think it would be good to document which parameters are out parameters. `IncludeNextTok` looks suspiciously like an out-parameter as well but is not AFAICT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119716/new/

https://reviews.llvm.org/D119716



More information about the cfe-commits mailing list