[PATCH] D119612: [clang] Pass more flags to ld64.lld

Mon Feb 14 06:58:59 PST 2022

lgrey added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:242
     } else if (D.getLTOMode() == LTOK_Thin)
       // If we are using thin LTO, then create a directory instead.
       TmpPathName = D.GetTemporaryDirectory("thinlto");
----------------
thakis wrote:
> lgrey: Do you think this should interact with 134275d994d5fb38edfeb587ba45c8f495c8bf66 in any way, or should have any other interesting side effects?
> 
> From what I understand, it tells the linker to put temporary files created for LTO in the given directory, but then the clang driver cleans up that directory when it exits (potentially after running dsymutil). But most people run dsymutil later, separately, so I think there should be no interactions there.
IIUC this is orthogonal to the cache's temp files. Something's actually not adding up here for me (why was it looking at the LTO cache files in the first place?), but this change shouldn't affect the cache thing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119612/new/

https://reviews.llvm.org/D119612