[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format
sstwcw via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 13 14:20:21 PST 2022
sstwcw abandoned this revision.
sstwcw added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:16854
+ // that things still get aligned.
+ Alignment.ColumnLimit = 20;
EXPECT_EQ("int a(int x,\n"
----------------
HazardyKnusperkeks wrote:
> I disagree. Limit 0 and Limit != 0 behaves differently and you should not remove the old test.
I hadn't noticed Limit != 0 behaves differently. Now I understand I don't need to change this test. I am going to close this diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119625/new/
https://reviews.llvm.org/D119625
More information about the cfe-commits
mailing list