[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 13 12:00:10 PST 2022

v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, balazske.
Herald added a reviewer: shafik.
v.g.vassilev requested review of this revision.

In case where we have removed all declarations for a given declaration name entry we should remove the whole StoredDeclsMap entry. This patch improves consistency in the lookup tables and helps cling/clang-repl error recovery.

  rC Clang



Index: clang/unittests/AST/ASTImporterTest.cpp
--- clang/unittests/AST/ASTImporterTest.cpp
+++ clang/unittests/AST/ASTImporterTest.cpp
@@ -4243,6 +4243,10 @@
   // This asserts in the old implementation.
+  // Make sure we do not leave a StoredDeclsList with no entries.
+  DC->removeDecl(A1);
+  ASSERT_EQ(Map->find(A1->getDeclName()), Map->end());
 struct ImportFunctionTemplateSpecializations
Index: clang/lib/AST/DeclBase.cpp
--- clang/lib/AST/DeclBase.cpp
+++ clang/lib/AST/DeclBase.cpp
@@ -1524,7 +1524,11 @@
       if (Map) {
         StoredDeclsMap::iterator Pos = Map->find(ND->getDeclName());
         assert(Pos != Map->end() && "no lookup entry for decl");
-        Pos->second.remove(ND);
+        StoredDeclsList &List = Pos->second;
+        List.remove(ND);
+        // Clean up the entry if there are no more decls.
+        if (List.isNull())
+          Map->erase(Pos);
     } while (DC->isTransparentContext() && (DC = DC->getParent()));

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119675.408285.patch
Type: text/x-patch
Size: 1177 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220213/aab6c3d4/attachment.bin>

More information about the cfe-commits mailing list