[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Sun Feb 13 01:03:52 PST 2022

cor3ntin added a comment.

In D119651#3317346 <https://reviews.llvm.org/D119651#3317346>, @erichkeane wrote:

> I'm pretty sure @cor3ntin just messed with this quite a bit, so I'd like to hear his thoughts on this. But this generally looks right on first blush.

Probably not as much as you haha.
There seems to be quite a number of consteval related issues still - https://reviews.llvm.org/D113859 is very similar - yet completely unrelated -

This patch does look okay to me, in so far as it fixes this issue, in a way that seems sensible to me. I'm just wondering if there are similar issues in other places...should we survey all the evaluation contexts to see see if that can occur in other places?
Should we maybe always treat `PotentiallyEvaluated` as `ConstantEvaluated` in constant evaluated contexts? could that work ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119651/new/

https://reviews.llvm.org/D119651