[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 11 18:18:19 PST 2022


junaire added a comment.

> I think we should probably have test coverage for `long double` as well, but I also wonder whether it makes sense to add coverage for the small floating-point types (like `_Float16`) as well, or whether we already have coverage for those elsewhere.

Test long double is fine for me. But I'm not really sure if we need to test for these half-precision floats, as they are part of clang language extension and not supported in all targets. IMHO, maybe we can just simply test these normal or standard floats first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119528/new/

https://reviews.llvm.org/D119528



More information about the cfe-commits mailing list