[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 11 06:57:57 PST 2022


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797
+    if (IsCompareCapture) {
+      // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore
+      // code gen.
+      unsigned DiagID = Diags.getCustomDiagID(
+          DiagnosticsEngine::Error,
+          "atomic compare capture is not supported for now");
+      Diag(AtomicKindLoc, DiagID);
----------------
Better not to emit error here, if possible. What's prevent this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116261/new/

https://reviews.llvm.org/D116261



More information about the cfe-commits mailing list