[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 10 12:01:03 PST 2022


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

LG, thanks!
You might want to check out how hover behaves and add a test there.



================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:948
 
   Code = R"cpp(
+    void test(id</*error-ok*/[[InvalidProtocol]]> p);
----------------
This new test case looks interesting, but can we keep the old one too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119366/new/

https://reviews.llvm.org/D119366



More information about the cfe-commits mailing list