[PATCH] D119446: [clang-cl] Accept the "legacy'"-target flag spelling

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 10 08:23:00 PST 2022

hans created this revision.
hans added a reviewer: thakis.
Herald added a subscriber: dang.
hans requested review of this revision.
Herald added a project: clang.

we already accept "--target=". No reason to not accept "-target" too (that's the one I typically use for some reason).

  rG LLVM Github Monorepo



Index: clang/test/Driver/cl-options.c
--- clang/test/Driver/cl-options.c
+++ clang/test/Driver/cl-options.c
@@ -772,4 +772,9 @@
 // FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}ucrt
 // FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}um
+// Accept both the -target and --target= spellings.
+// RUN: %clang_cl --target=i686-pc-windows-msvc19.14.0 -### -- %s 2>&1 | FileCheck -check-prefix=TARGET %s
+// RUN: %clang_cl -target i686-pc-windows-msvc19.14.0  -### -- %s 2>&1 | FileCheck -check-prefix=TARGET %s
+// TARGET: "-triple" "i686-pc-windows-msvc19.14.0"
 void f() { }
Index: clang/include/clang/Driver/Options.td
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -4442,7 +4442,9 @@
 // These are legacy user-facing driver-level option spellings. They are always
 // aliases for options that are spelled using the more common Unix / GNU flag
 // style of double-dash and equals-joined flags.
-def target_legacy_spelling : Separate<["-"], "target">, Alias<target>;
+def target_legacy_spelling : Separate<["-"], "target">,
+                             Alias<target>,
+                             Flags<[CoreOption]>;
 // Special internal option to handle -Xlinker --no-demangle.
 def Z_Xlinker__no_demangle : Flag<["-"], "Z-Xlinker-no-demangle">,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119446.407545.patch
Type: text/x-patch
Size: 1472 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220210/fe432749/attachment.bin>

More information about the cfe-commits mailing list