[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 10 04:51:32 PST 2022


svenvh added a comment.

In D119398#3310746 <https://reviews.llvm.org/D119398#3310746>, @Anastasia wrote:

> This might interfere with https://reviews.llvm.org/D119420

Yes it will conflict.

Atomic doubles are not guarded properly for other builtins (outside of the `cl_ext_float_atomics` extensions) either, and I have a different solution in mind to solve it for all uses and extensions.  So we could leave out the .td changes from this patch and only merge the `opencl-c.h` changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119398/new/

https://reviews.llvm.org/D119398



More information about the cfe-commits mailing list