[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

[Evgeny Shulgin via Phabricator via cfe-commits]

Izaron marked an inline comment as done.
Izaron added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:16731
       /*IsImmediateInvocation*/ true);
-  ExprEvalContexts.back().ImmediateInvocationCandidates.emplace_back(Res, 0);
+  /// Value-dependent constant expression are not meant to be calculated.
+  /// Each template instantiation will calculate its own value later.
----------------
cor3ntin wrote:
> I'd say something like
> 
> /// Value-dependent constant expressionS should not be immediately
> // evaluated until they are instantiated.
Sure, thanks! I'm bad at writing comments =)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119375/new/

https://reviews.llvm.org/D119375